Fix offset values for PMIC I2C in the pinctrl generation script. #584
+14
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the scripts offset value for the PMIC I2C signals when using RT7XX Devices. An accidental prefix '0x' was added to the offset's actual decimal value. e.g. 96 -> 0x96. Real value should be 96 -> 0x60. Signed-off-by: Emilio Benavente <[email protected]>
Updated the offset values for the PMIC I2C to point to the correct offset values. Signed-off-by: Emilio Benavente <[email protected]>
DerekSnell
approved these changes
Aug 7, 2025
mmahadevan108
approved these changes
Aug 13, 2025
| @@ -14,8 +14,8 @@ | |||
| (((offset) & 0xFFF) << 20) | \ | |||
| (((mux) & 0xF) << 0)) | |||
|
|
|||
| #define PMIC_I2C_SCL IOPCTL_MUX(1, 150, 0) /* PIO0_0 */ | |||
| #define PMIC_I2C_SDA IOPCTL_MUX(1, 151, 0) /* PIO0_0 */ | |||
There was a problem hiding this comment.
Did you rerun the script or was this manually fixed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix offset values for PMIC I2C in the pinctrl generation script.
e.g. 96 -> 0x60 and not 96 -> 0x96.